calendar done #3887
calendar done #3887
Conversation
gabai62
commented
Oct 21, 2024
gabai62
commented
- DEMO LINK
- TEST REPORT LINK
- Changing 'month-lengh' and 'start-day' modifier in the code element reflects in changing calendar layout
- Each day has no modifiers, only class (eg. calendar__day)
- All Typical Mistakes from BEM lesson theory are checked.
- Code follows all the Code Style Rules ❗️
There was a problem hiding this comment.
The SCSS file is well-structured, but there's a critical issue with the link tag in your HTML. Please ensure the href attribute points to the compiled CSS file instead of the SCSS file. Once this is fixed, your work will be ready to go! Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
| @@ -9,10 +9,42 @@ | |||
| <title>Calendar</title> | |||
| <link | |||
| rel="stylesheet" | |||
| href="styles/index.scss" | |||
| href="styles/main.scss" | |||
There was a problem hiding this comment.
The href attribute in the link tag should point to a CSS file, not a SCSS file. SCSS files need to be compiled into CSS before they can be used in an HTML document. Please ensure that the href attribute points to the correct CSS file.
There was a problem hiding this comment.
Great job on structuring the SCSS file and effectively using variables, loops, and mixins! 🎉 While the code is well-organized, make sure to review any comments for potential improvements. Address any critical issues in future projects to enhance your skills. Keep up the good work and continue learning! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
