solution #3895
solution #3895
Conversation
SerhiiUnhurian
commented
Oct 23, 2024
SerhiiUnhurian
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a couple of critical issues that need to be addressed before we can proceed. The stylesheet link in the HTML file should point to a compiled CSS file instead of a '.scss' file, as browsers cannot interpret Sass files directly. Additionally, please correct the typo in the SCSS file by changing '$sell-size' to '$cell-size' for consistency and clarity. Once these changes are made, we can move forward. Keep up the great work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| @@ -13,6 +13,41 @@ | |||
| /> | |||
There was a problem hiding this comment.
The href attribute points to a '.scss' file, which is a Sass file. Browsers cannot directly interpret Sass files; they need to be compiled into CSS. Ensure that you are linking to a compiled CSS file instead.
| @@ -1,3 +1,74 @@ | |||
| $sell-size: 100px; | |||
There was a problem hiding this comment.
The variable name '$sell-size' appears to be a typo. It is likely intended to be '$cell-size', as it represents the size of each calendar cell.
| transition: all 0.5s; | ||
|
|
||
| &:first-child { | ||
| margin-left: (6 * $sell-size) + (6 * $gap-size); |
There was a problem hiding this comment.
The use of '$sell-size' here should be corrected to '$cell-size' to maintain consistency with the intended variable naming.
|
|
||
| @each $day, $offset in $days { | ||
| .calendar--start-day-#{$day} .calendar__day:first-child { | ||
| margin-left: ($offset * $sell-size) + ($gap-size * $offset); |
There was a problem hiding this comment.
Ensure that '$sell-size' is corrected to '$cell-size' for consistency and clarity in the code.
