Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eco-cosmetics #455

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

eco-cosmetics #455

wants to merge 3 commits into from

Conversation

NataliMax
Copy link

No description provided.

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images overlapping menu - to fix incease z-ndex for menu
2023-09-20_15h05_05

My assumption type text will be better for this imput
https://github.com/mate-academy/layout_creativeBakery/assets/61904995/3ce4bf76-7e14-46ff-8898-4bca7f2e5b90

One more case with menu - it should be full height on mobile resolution too
https://github.com/mate-academy/layout_creativeBakery/assets/61904995/bab1914a-081a-42a5-bf79-19fd09200274

@VitaliyBondarenko1982
Copy link

DEMO LINK

Copy link

@Viktor-Kost Viktor-Kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

To improve:

  1. either use with a capital letter or not
Screenshot 2023-09-28 at 14 40 30 Screenshot 2023-09-28 at 14 40 39
  1. when i get into this page https://natalimax.github.io/layout_creativeBakery/card.html. I click at logo and suppose to be sent to the main page, yet it doesn't work. So, improve logo link to always return to the main page

  2. this hover effect is a little bit confusing. Just use learn more as a button
    https://github.com/mate-academy/layout_creativeBakery/assets/117587463/3dc0bb06-d08d-46f2-bf79-bc2092ee28ac

  3. increase images on hover

  4. remove a default button border

Screenshot 2023-09-28 at 14 46 13

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These previous comment were not fixed
image

@NataliMax
Copy link
Author

image

@NataliMax
Copy link
Author

Cпробуй оновити, у мене все працює

@NataliMax NataliMax requested a review from maxim2310 September 29, 2023 07:13
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants