Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is only mobile version of website #464

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

oleksandrshtonda
Copy link

DEMO LINK

P.S. I know, that there's only mobile version of website. Also I've seen, that I need to center the cookie in the header.

:)

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile version looks good.
Looks like just menu not implemented.
Waiting implementation for all width of screens

@TarasHoliuk
Copy link

Read the checklist and make sure you do everything according to it's rules

  1. Comments about the menu:
  • disable scroll when the menu is open
  • use the same padding (tablet version) for content - the "X" button should be in the same place as the "burger" button, and the same for logo

image

  1. Scroll should be smooth on an anchor link click

  2. Add a hover effect for interactive elements (links) in addition to cursor: pointer. Social media icons should be links to corresponding social media sites (main page), do not forget open external links in the new tab:

image

  1. Add hover effect for images

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 👍
Let's make your app even better (read comments)

@oleksandrshtonda
Copy link
Author

I get it. Could you tell me please, how can I disable scroll when I open the menu? I've added overflow: hidden to .menu but scroll still available :/

@oleksandrshtonda
Copy link
Author

oleksandrshtonda commented Oct 8, 2023

I have 1 problem. The commnad npm run deploy doesn't work

P.S. now it works :D

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice!
Screenshot 2023-10-08 at 16 40 00

  1. The logo should be a link to the index page.
Screenshot 2023-10-08 at 16 40 22 2. Interactive elements should have hover styles 3. The phone link doesn’t work 4. The scroll should be smooth Screenshot 2023-10-08 at 16 43 49 5. The order also should be the link or a button element Screenshot 2023-10-08 at 16 44 38 Screenshot 2023-10-08 at 16 44 46 6. Check margins between sections Screenshot 2023-10-08 at 16 46 19 7. Consider disabling page scroll when the menu is open 8. Add hovers for gallery images Screenshot 2023-10-08 at 16 45 26 9. Social media links should lead to the blank tab with the first page of proper social media

Copy link

@nazarmatsevych nazarmatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants