Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #552

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Develop #552

wants to merge 5 commits into from

Conversation

lmuias
Copy link

@lmuias lmuias commented Mar 6, 2024

DEMO LINK.
Also i added theme switcher from light blue color to pink with changing titles color and background.

@TarasHoliuk
Copy link

  1. Add external (open in the new tab) links to the corresponding social media sites:
    image

  2. First of all: that's amazing you've implemented a theme switcher 🔥 But I'd recommend you move it - place it right after (preferred) or before navigation links (or menu button for mobile/tablet version) and add some text (Theme or Change theme). Or even better - add some icon near the swither. Because now it's not clear what this swither does

TarasHoliuk
TarasHoliuk suggested changes Mar 6, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍
2 small comments

@lmuias lmuias requested a review from TarasHoliuk March 6, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viktor-Kost Viktor-Kost Viktor-Kost approved these changes

@TarasHoliuk TarasHoliuk Awaiting requested review from TarasHoliuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmuias @TarasHoliuk @Viktor-Kost