Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #588

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #588

wants to merge 2 commits into from

Conversation

RainerWerner44
Copy link

DanilWeda
DanilWeda approved these changes Jun 20, 2024
View reviewed changes
Copy link

@DanilWeda DanilWeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Great job.
Ui fixes (not critical):
On phone/ small tablet you can align order buttons in one line.

image

Code tips:
Using static width and height in places where you really need that.

I approved this request with small minor issues.
Thanks)

@RainerWerner44
Copy link
Author

fixed it with fixed height fro cards descs

@RainerWerner44 RainerWerner44 requested a review from DanilWeda June 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanilWeda DanilWeda Awaiting requested review from DanilWeda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RainerWerner44 @DanilWeda