Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #617

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

DmytroPAvlichenko
Copy link

@TarasHoliuk
Copy link

  1. Add hover effect directly to the link:

image

Now it is displayed below the padding

  1. Open all external links in the new tab (it's general rule):

image

P.S. It doesn't look critical here, but it's better to use SVG image (you can select this option when exporting images from Figma) for icons and logos. Reason - better quality (especially on bigger screens)

  1. Typo - more instead of mode. Also, it should be in UPPER CASE:
    image

Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Almost done 👍
A few small comments

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Screenshot 2024-10-06 at 13 27 34
Screenshot 2024-10-06 at 13 27 40
Check the title here. There is one string in the Figma
Screenshot 2024-10-06 at 13 25 27
Screenshot 2024-10-06 at 13 25 32
Check icon hovers

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants