Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #631

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #631

wants to merge 4 commits into from

Conversation

nadiia21
Copy link

No description provided.

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 14, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no demo link, also, you need to add demo link to the PR description
image

@nadiia21
Copy link
Author

DEMO LINK

volodymyr-soltys97
volodymyr-soltys97 suggested changes Nov 14, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add hover effects for all clickable elements on the page
image
  1. Add a better favicon on the page
image

You can use icon from this image
image

etojeDenys
etojeDenys suggested changes Nov 14, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks different
image
image
image
image

@nadiia21 nadiia21 requested a review from etojeDenys November 15, 2024 10:53
VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Nov 15, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nadiia21 @VitaliyBondarenko1982 @volodymyr-soltys97 @etojeDenys