Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page #1871

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Landing page #1871

wants to merge 8 commits into from

Conversation

SerMamchur
Copy link

@SerMamchur
Copy link
Author

DEMO LINK

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let's improve your page

  1. Add the topical title and favicon on the page
image
  1. Add transition when this menu appears on the page
image
  1. Add hover effects for all clickable elements on the page
image
  1. The prices must be are on the same horizontal line and fix font weight here
image
  1. Fix default color for this button
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Hide the additional phone number on the mobile and tablet versions
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Almost done!

  • Screenshot 2024-12-15 at 13 54 10
  • The menu should be scrollable in the landscape mode
  • Screenshot 2024-12-15 at 13 52 30
  • Consider removing default outlines
  • Check fonts here
  • Screenshot 2024-12-15 at 13 51 43
  • Consider removing default borders

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Almost done.
Content not centered. Check wide screen (approximately more 1500px).
Screenshot 2024-12-16 at 14 35 12

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, your demo link isn't working, you need to make a deploy and check it after the demo link
image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants