Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #1874

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add task solution #1874

wants to merge 5 commits into from

Conversation

kirill-mate
Copy link

etojeDenys
etojeDenys suggested changes Dec 13, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image looks broken
  1. number should appear on hover
image

anastasiiavorobiova
anastasiiavorobiova suggested changes Dec 15, 2024
View reviewed changes
Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-12-15 at 13 40 48
  • Sections overlap on the scroll. Consider fixing it
  • Screenshot 2024-12-15 at 13 40 31
  • Check the background position for tablets
  • Screenshot 2024-12-15 at 13 40 08
  • Check fonts here
  • Consider removing default outlines
  • Screenshot 2024-12-15 at 13 39 50
  • Consider using mailto link here
  • Screenshot 2024-12-15 at 13 39 10
  • Consider showing the phone number on the hover
  • Screenshot 2024-12-15 at 13 39 05
  • Check styles here

VitaliyBondarenko1982
VitaliyBondarenko1982 approved these changes Dec 16, 2024
View reviewed changes
Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitaliyBondarenko1982 VitaliyBondarenko1982 VitaliyBondarenko1982 approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

@anastasiiavorobiova anastasiiavorobiova Awaiting requested review from anastasiiavorobiova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirill-mate @VitaliyBondarenko1982 @etojeDenys @anastasiiavorobiova