Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish landing page #1886

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Finish landing page #1886

wants to merge 3 commits into from

Conversation

Andrew1256
Copy link

No description provided.

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there is no styles on the demo, you need to make deploy and check it after demo link
image

@@ -14,7 +14,7 @@ Follow the videos in this and next lessons to implement the page block by block
- Start writing styles in the `main.scss` file. It is be explained in the `Sass` lesson
- **DON'T** try to do it `Pixel Perfect` - implement it the most `simple` way so it looks similar;
- When done check yourself using the [CHECKLIST](./checklist.md) when finished;
- Deploy and create a Pull Request with a [DEMO LINK](https://<your_account>.github.io/layout_landing-page/)
- Deploy and create a Pull Request with a [DEMO LINK](https://Andrew1256.github.io/layout_landing-page/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add demo link to the PR description
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants