Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #1887

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add task solution #1887

wants to merge 2 commits into from

Conversation

GumenchukAN
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
Let's improve your page

  1. You need to show additional phone number when hovering this icon
image
  1. Add the topical title and favicon on the page
image
  1. Remove scroll when the menu is open
image
  1. You need to change image for header, without red border
image
  1. Add hover effects for images
image
  1. Fix gap between these elements, check it on the design
image
  1. Make all these fields are required before sending
image
  1. Add cursor pointer for all clickable elements
image
  1. All these elements must be links and add hover effects here
image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not open new tab on phone click
image

  1. button should be inside the form
  2. add "required" attribute to all inputs
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants