Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #4829

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add solution #4829

wants to merge 5 commits into from

Conversation

seriuksergii
Copy link

  • [ x ] Header height is set in 1 place (for the links)
  • [ x ] Content is vertically centered (for any header height)
  • [ x ] CSS is used to show all letters in Uppercase (don't type them in HTML)
  • [ x ] Logo is an image wrapped with a link
  • [ x ] CSS Variable is used for a blue color
  • [ x ] Pseudo-element is used for a blue line below the active link
  • [ x ] Code follows all the Code Style Rules ❗️

Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to add demo and test links to the PR description. Try to pass all tests

  1. The header should have box-shadow property
    image
  2. Hover effect doesn't work correctly. The whole height of the link should be clickable
    links

@seriuksergii
Copy link
Author

[ x ] Header height is set in 1 place (for the links)
[ x ] Content is vertically centered (for any header height)
[ x ] CSS is used to show all letters in Uppercase (don't type them in HTML)
[ x ] Logo is an image wrapped with a link
[ x ] CSS Variable is used for a blue color
[ x ] Pseudo-element is used for a blue line below the active link
[ x ] Code follows all the Code Style Rules ❗️

@seriuksergii
Copy link
Author

@seriuksergii seriuksergii requested a review from polosanya April 29, 2024 10:10
@seriuksergii
Copy link
Author

@seriuksergii
Copy link
Author

@seriuksergii seriuksergii reopened this Apr 30, 2024
Copy link

@roman-mirzoian roman-mirzoian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, but pay attention to the comments.
And next time, be more careful, if something doesn't work out, ask for help in the qna channel.

<img
class="logo__img"
src="images/logo.png"
alt="Logo"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the standard format.
For logos, use the format: "[Organization name] logo."

image

color: black;
text-decoration: none;
font-family: Roboto, sans-serif;
font-style: normal;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This default value does not need to be set.

padding: 0 50px;
}


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants