-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #4829
base: master
Are you sure you want to change the base?
add solution #4829
Conversation
seriuksergii
commented
Apr 7, 2024
- [ x ] Header height is set in 1 place (for the links)
- [ x ] Content is vertically centered (for any header height)
- [ x ] CSS is used to show all letters in Uppercase (don't type them in HTML)
- [ x ] Logo is an image wrapped with a link
- [ x ] CSS Variable is used for a blue color
- [ x ] Pseudo-element is used for a blue line below the active link
- [ x ] Code follows all the Code Style Rules ❗️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ x ] Header height is set in 1 place (for the links) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, but pay attention to the comments.
And next time, be more careful, if something doesn't work out, ask for help in the qna channel.
<img | ||
class="logo__img" | ||
src="images/logo.png" | ||
alt="Logo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
color: black; | ||
text-decoration: none; | ||
font-family: Roboto, sans-serif; | ||
font-style: normal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This default value does not need to be set.
padding: 0 50px; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.