Develop #4895
Open
Develop #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 16, 2024 17:19
nazarmatsevych
suggested changes
Apr 28, 2024
src/index.html
Outdated
| </li> | ||
| <li class="nav-item"> | ||
| <a | ||
| href="#" |
There was a problem hiding this comment.
Add appropriate href value
Suggested change
| href="#" | |
| href="#Samsung" |
src/index.html
Outdated
Comment on lines
67
to
75
| <li class="nav-item"> | ||
| <a | ||
| href="#" | ||
| class="nav-link" | ||
| > | ||
| Smartphones | ||
| </a> | ||
| </li> | ||
| <li class="nav-item"> |
There was a problem hiding this comment.
Suggested change
| <li class="nav-item"> | |
| <a | |
| href="#" | |
| class="nav-link" | |
| > | |
| Smartphones | |
| </a> | |
| </li> | |
| <li class="nav-item"> | |
| <li class="nav-item"> | |
| <a | |
| href="#" | |
| class="nav-link" | |
| > | |
| Smartphones | |
| </a> | |
| </li> | |
| <li class="nav-item"> |
Add an empty line between multiple sibling blocks of html
src/style.css
Outdated
| body { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; |
src/style.css
Outdated
| body { | ||
| margin: 0; | ||
| padding: 0; |
There was a problem hiding this comment.
Body doesn't have default padding
src/style.css
Outdated
Comment on lines
11
to
13
| ul { | ||
| list-style-type: none; | ||
| } |
There was a problem hiding this comment.
Reset default ul padding and margin
Suggested change
| ul { | |
| list-style-type: none; | |
| } | |
| ul { | |
| list-style-type: none; | |
| margin: 0; | |
| padding: 0; | |
| } |
src/style.css
Outdated
|
|
||
| .nav-item { | ||
| position: relative; | ||
| padding: 22.5px 0; |
There was a problem hiding this comment.
Suggested change
| padding: 22.5px 0; | |
| padding: 23px 0; |
It should help with failed tests
src/style.css
Outdated
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| margin: 0 50px; |
There was a problem hiding this comment.
Suggested change
| margin: 0 50px; | |
| padding: 0 50px; |
vadiimvooo
suggested changes
Apr 28, 2024
src/style.css
Outdated
| body { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; |
src/style.css
Outdated
|
|
||
| .nav-item { | ||
| position: relative; | ||
| padding: 23px 0; |
There was a problem hiding this comment.
Add line-height for nav-link instead of this paddings to pass the tests
nazarmatsevych
suggested changes
Apr 29, 2024
| <!-- logo --> | ||
| <a | ||
| href="#" | ||
| class="logo" |
There was a problem hiding this comment.
Add font-size: 0 to logo class to remove this extra space
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| padding: 0 50px; |
There was a problem hiding this comment.
add min-width: 1024px to limit minimal width of header due to design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️