Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

priemssonia
Copy link

Copy link

@dinaminahi dinaminahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I can't see your site, and can't check the tests, the links don't work
Have you run deploy?

image

src/style.css Outdated
Comment on lines 1 to 4
* {
box-sizing: border-box;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to use * selector, you can set this on those elements you need
image

src/style.css Outdated
justify-content: space-between;
box-sizing: border-box;
padding-left: 50px;
height: 60px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set the height to the link itself, not the header

image

@priemssonia priemssonia requested a review from dinaminahi May 2, 2024 16:54
Copy link

@dinaminahi dinaminahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants