add task solution

[roksolanap]

• Header height is set in 1 place (for the links)
• Content is vertically centered (for any header height)
• CSS is used to show all letters in Uppercase (don't type them in HTML)
• Logo is an image wrapped with a link
• CSS Variable is used for a blue color
• Pseudo-element is used for a blue line below the active link
• Code follows all the Code Style Rules ❗️

[TarasHoliuk]

Add links to the demo and tests report to PR description (19 here)

Try to pass all tests, feel free to ask for help in the chat if you need

[TarasHoliuk]

better not adding a lot of styles to * selector without necessary

For example, if you add font-family and font-size to body they will be inherited by all nested elements
It is not a good idea to reset the margin for all elements, better to do it for the list of tags you really need

What really should be here is box-sizing property

[TarasHoliuk]

bottom: 0 instead of "magic" 34px top

[TarasHoliuk]

do not add styles using combined selectors without necessary
just add class for all li elements and use this class to add styles

fix all similar cases

[TarasHoliuk]

you can list selectors with same styles separated by comma:

.example-selector-1,
.example-selector-2,
.example-selector-3:hover {
  // some styles
}

[volodymyr-soltys97]

Hi, there is no demo link, also you need to add the demo link to the Pull Request description

[volodymyr-soltys97]

fix class everywhere

Suggested change

	<li class="nav_li">
	<li class="nav__item">

[volodymyr-soltys97]

The same as above

Suggested change

	class="is-active nav_a"
	class="is-active nav__link"

[volodymyr-soltys97]

This color is default

Suggested change

background-color: var(--header-color);

[roksolanap]

• Header height is set in 1 place (for the links)
• Content is vertically centered (for any header height)
• CSS is used to show all letters in Uppercase (don't type them in HTML)
• Logo is an image wrapped with a link
• CSS Variable is used for a blue color
• Pseudo-element is used for a blue line below the active link
• Code follows all the Code Style Rules ❗️

[etojeDenys]

you forgot to provide these two important links in the PR description

[etojeDenys]

Suggested change

	.nav__link:hover {
	color: var(--nav-active);
	}
	.is-active {
	color: var(--nav-active);
	}
	.nav__link:hover,
	.is-active {
	color: var(--nav-active);
	}

[roksolanap]

done, thank you

[roksolanap]

• Header height is set in 1 place (for the links)
• Content is vertically centered (for any header height)
• CSS is used to show all letters in Uppercase (don't type them in HTML)
• Logo is an image wrapped with a link
• CSS Variable is used for a blue color
• Pseudo-element is used for a blue line below the active link
• Code follows all the Code Style Rules ❗️

[lerastarynets]

You've got this, keep pushing forward!