Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5611

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Develop #5611

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
caef7a8
header base
pat5513 Oct 19, 2024
1c46c71
styling improve
pat5513 Oct 20, 2024
d1be9a3
hover underlines
pat5513 Oct 20, 2024
2aa6a8b
style touch
pat5513 Oct 20, 2024
6c2a207
padding improve
pat5513 Oct 20, 2024
6768f5f
is-active link
pat5513 Oct 20, 2024
c5ecaca
develop
pat5513 Oct 28, 2024
8b22843
nav gap fix
pat5513 Oct 29, 2024
6f16aba
code fix
pat5513 Oct 29, 2024
8cbef9c
title fix
pat5513 Dec 15, 2024
88474d4
Merge branch 'develop' of https://github.com/pat5513/layout_moyo-head…
pat5513 Dec 15, 2024
2bcd387
header height fix
pat5513 Dec 15, 2024
e107463
code fix
pat5513 Dec 15, 2024
b169e94
style fix
pat5513 Dec 16, 2024
05c73c0
final change
pat5513 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Moyo header

Create HTML page with the header using `flexbox` based on the [Figma Mockup](https://www.figma.com/file/1sog2rmfyCjnVxkeZ3ptnc/MOYO-%2F-Header?node-id=0%3A1&mode=dev).

The page should match the design Pixel Perfect: all the sizes, colors and distanced MUST be the same as on the design.
Expand Down Expand Up @@ -27,8 +28,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://pat5513.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://pat5513.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
104 changes: 102 additions & 2 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<html lang="en">
<head>
<meta charset="UTF-8" />
<title>Moyo header</title>
<meta
name="viewport"
content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"
Expand All @@ -10,13 +11,112 @@
http-equiv="X-UA-Compatible"
content="ie=edge"
/>
<title>Moyo header</title>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap"
rel="stylesheet"
/>
<link
rel="stylesheet"
href="./style.css"
/>
</head>

<body>
<h1>Moyo header</h1>
<header class="header">
<a
href="index.html"
class="header__logo"
>
<img
src="images/logo.png"
alt="moyo logo"
/>
</a>

<nav class="navigation">
<ul class="nav_list">
<li class="nav_item">
<a
href="index.html"
class="is-active nav_link"
>
apple
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
>
samsung
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
>
smartphones
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
data-qa="hover"
>
laptops & computers
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
>
gadgets
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
>
tablets
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
>
photo
</a>
</li>

<li class="nav_item">
<a
href="index.html"
class="nav_link"
>
video
</a>
</li>
</ul>
</nav>
</header>
</body>
</html>
74 changes: 74 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,77 @@
:root {
--link-on: #00acdc;
--link-off: black;
}

body {
margin: 0;
font-family: Roboto, sans-serif;
font-weight: 500;
}

.header {
display: flex;
justify-content: space-between;
padding: 0 50px;
}

.header__logo {
align-self: center;
display: flex;
}

.navigation {
display: flex;
align-items: center;
}

.nav_list {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ul tag is also applying some left padding. Thats why test's are failing.

display: flex;
list-style: none;
margin: 0;
}

.nav_item {
display: flex;
}

.nav_link {
color: var(--link-off);
text-decoration: none;
font-size: 12px;
text-transform: uppercase;
align-items: center;
display: flex;
height: 60px;
margin-left: 20px;
}

.nav_link:visited {
color: var(--link-off);
}

.nav_link:hover {
color: var(--link-on);
}

.nav_link:active {
color: var(--link-on);
position: relative;
}

.is-active {
color: var(--link-on);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color is not applied to the active link because .nav_link:visited has higher specificity. You have to increase specificity of this selector to apply that active color.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be

.nav_link.is_active {
}

To be more precise

margin-left: 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset of margin with is-active is bad. You should use :first-child pseudo class fro this

position: relative;
}

.is-active::after {
content: '';
display: block;
border-bottom: 4px solid var(--link-on);
position: absolute;
border-radius: 2px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that border radius on that underline should be higher. In figma i believe its 8px

left: 0;
right: 0;
bottom: 0;
}
Loading