Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #5613

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add solution #5613

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
808e33c
add solution
Vlad-2608 Oct 28, 2024
a6c347e
add solution
Vlad-2608 Oct 31, 2024
0cd31f9
add new color
Vlad-2608 Nov 5, 2024
bc132b2
add correct
Vlad-2608 Dec 2, 2024
b417d90
add correct
Vlad-2608 Dec 2, 2024
2baefab
add correct
Vlad-2608 Dec 5, 2024
26086ce
add corect
Vlad-2608 Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ The page should match the design Pixel Perfect: all the sizes, colors and distan

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_moyo-header/report/html_report/)
- [DEMO LINK](https://Vlad-2608.github.io/layout_moyo-header/)
- [TEST REPORT LINK](https://Vlad-2608.github.io/layout_moyo-header/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
104 changes: 103 additions & 1 deletion src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,110 @@
rel="stylesheet"
href="./style.css"
/>

<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
/>
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap"
rel="stylesheet"
/>
</head>
<body>
<h1>Moyo header</h1>
<header class="header">
<a
href="home-page"
class="img"
>
<img
src="./images/logo.png"
alt="Moyo-Logo"
/>
</a>

<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#apple"
class="nav__link is-active"
>
APPLE
</a>
</li>

<li class="nav__item">
<a
href="#samsung"
class="nav__link"
>
SAMSUNG
</a>
</li>

<li class="nav__item">
<a
href="#smartphones"
class="nav__link"
>
SMARTPHONES
</a>
</li>

<li
class="nav__item"
data-qa="hover"
>
<a
href="#laptop&computers"
class="nav__link"
>
LAPTOPS & COMPUTERS
</a>
</li>

<li class="nav__item">
<a
href="#gadgets"
class="nav__link"
>
GADGETS
</a>
</li>

<li class="nav__item">
<a
href="#tablets"
class="nav__link"
>
TABLETS
</a>
</li>

<li class="nav__item">
<a
href="#photo"
class="nav__link"
>
PHOTO
</a>
</li>

<li class="nav__item">
<a
href="#video"
class="nav__link"
>
VIDEO
</a>
</li>
</ul>
</nav>
</header>
</body>
</html>
60 changes: 60 additions & 0 deletions src/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,63 @@
body {
--color: #00acdc;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a variable with root selector

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed


margin: 0;
}

.header {
width: 100%;
display: flex;
justify-content: space-between;
align-items: center;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.header {
width: 100%;
display: flex;
justify-content: space-between;
align-items: center;
}
.header {
width: 100%;
display: flex;
justify-content: space-between;
align-items: center;
padding: 0 50px
}


.nav__link {
font-size: 12px;
text-decoration: none;
color: #000;
padding-top: 22px;
padding-bottom: 22px;
}

.nav__list {
list-style-type: none;
display: flex;
flex-wrap: nowrap;
}

.nav__item {
font-weight: 600;
text-transform: uppercase;
margin-right: 20px;
}

.nav {
padding-right: 30px;
font-family: Roboto, Arial, sans-serif;
}

.img {
height: 40px;
width: 40px;
margin-top: 10px;
margin-left: 50px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-left: 50px;

}

.is-active {
position: sticky;
}

.is-active::after {
position: absolute;
content: '';
left: 0;
width: 100%;
bottom: 0;
height: 4px;
background-color: var(--color);
border-radius: 10px;
}

.nav__link:hover {
color: var(--color);
}
Loading