Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #5786

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

add solution #5786

wants to merge 13 commits into from

Conversation

diachkinainna
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [x ] Header height is set in 1 place (for the links)

  • [ x] Content is vertically centered (for any header height)

  • [ x] CSS is used to show all letters in Uppercase (don't type them in HTML)

  • [x ] Logo is an image wrapped with a link

  • [x ] CSS Variable is used for a blue color

  • [x ] Pseudo-element is used for a blue line below the active link

  • [ x] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
[CODE: 4]

Additional info:
Ignored files list:

  • src/index.html
  • src/style.css

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo links leads to 404 page.
Looks like wasn't any deploys for this task.
https://github.com/diachkinainna/layout_moyo-header/actions

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/style.css Outdated
margin-left: 20px;
}

a.is-active {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a.is-active {
.is-active {

redundant a

src/style.css Outdated
color: var(--active-link-color);
}

a.is-active::after {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
a.is-active::after {
.is-active::after {

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants