Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #5803

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Elvira-Bariieva
Copy link

DEMO LINK

Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort on your project! 🎉 While there are several areas for improvement, such as ensuring unique href attributes for navigation links and correctly using CSS properties like font-family, your code is on the right track. Remember to wrap your logo in a link for better semantic HTML and address the indentation and class naming conventions for clarity and maintainability. These adjustments will enhance your code's functionality and readability. Keep up the good work, and use this feedback to refine your skills further. Happy coding! 💪

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated
</li>

<li>
<a href="index.html">Gadgets</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute for this link is set to index.html. Check if this should link to a different page for 'Gadgets'.

src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/index.html Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
src/style.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants