-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5818
base: master
Are you sure you want to change the base?
add task solution #5818
Conversation
NadiiaBulmak
commented
Dec 15, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While you've done a great job overall, there are a couple of critical issues that need to be addressed before we can approve the pull request:
-
Class Name Consistency: In the CSS file, the class name
.logo__image
is used, but in the HTML file, the classlogo__moyo
is used for the image. Please ensure that class names are consistent between the HTML and CSS to ensure proper styling. -
Typo in Navigation Link: There is a typo in one of the
href
attribute values. It should be'samsung'
instead of'samsund'
. This needs to be corrected to ensure the link functions as expected.
Once these issues are resolved, your code will be in great shape! Keep up the good work, and feel free to reach out if you have any questions or need further assistance. 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#samsund" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the href attribute value. It should be 'samsung' instead of 'samsund'.
margin: 0 auto; | ||
} | ||
|
||
.logo__image { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name '.logo__image' is used here, but in the HTML file, the class 'logo__moyo' is used for the image. Ensure consistency in class names between HTML and CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on addressing the issues in your code! 🎉 You've successfully resolved the class name inconsistency by ensuring the HTML now uses the class logo__image
, which matches the CSS. Additionally, the typo in the href
attribute has been corrected from #samsund
to #samsung
, ensuring the link functions properly.
While the decision is to APPROVE your pull request to help you move forward with your learning, it's important to remember the significance of maintaining consistency between HTML and CSS class names to ensure styles are applied correctly. Also, always double-check for typos in your code to avoid functionality issues.
Keep up the good work, and continue to learn from these experiences to improve your coding skills! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<img | ||
src="images/logo.png" | ||
alt="logo__image" | ||
class="logo__moyo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class name logo__moyo
used here does not match the class name .logo__image
used in the CSS file. Please ensure consistency between HTML and CSS class names.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#samsund" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the href
attribute. It should be #samsung
instead of #samsund
to ensure the link functions correctly.
margin: 0 auto; | ||
} | ||
|
||
.logo__image { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class .logo__image
here does not match the class name logo__moyo
used in the HTML file. Please ensure consistency between HTML and CSS class names to apply the styles correctly.