-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5819
base: master
Are you sure you want to change the base?
add task solution #5819
Conversation
Evergardn
commented
Dec 15, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 The code is well-structured and meets most of the task requirements. There are a few minor improvements suggested, such as updating the alt
attribute for better accessibility and ensuring CSS styles align with best practices. Keep up the good work and consider these suggestions for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<h1>Moyo header</h1> | ||
<header class="header"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
<ul class="nav__list"> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.
</li> | ||
<li class="nav__item"> | ||
<a | ||
href="#" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href="#"
attribute in the anchor tag is a placeholder. Ensure to replace it with actual URLs or routes if this is not intended for a single-page application.