Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moyo header #5852

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Moyo header #5852

wants to merge 13 commits into from

Conversation

sdoskich
Copy link

  • Header height is set in 1 place (for the links)
  • Content is vertically centered (for any header height)
  • CSS is used to show all letters in Uppercase (don't type them in HTML)
  • Logo is an image wrapped with a link
  • CSS Variable is used for a blue color
  • Pseudo-element is used for a blue line below the active link
  • Code follows all the Code Style Rules

TEST REPORT LINK: https://github.com/sdoskich/layout_moyo-header/blob/master/reports/html_report/index.html

DEMO LINK: https://sdoskich.github.io/layout_moyo-header/

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
[CODE: 10]

Additional info:
Files with too large content:

  • reports/html_report/index_bundle.js

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
[CODE: 10]

Additional info:
Files with too large content:

  • reports/html_report/index_bundle.js

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
[CODE: 10]

Additional info:
Files with too large content:

  • reports/html_report/index_bundle.js

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

Too many changes in the pull request. Please make sure that you have added only the necessary changes to the pull request.
[CODE: 6]

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo links is not correct.
Use demo links from readme.md file in project.

src/style.css Outdated
justify-content: flex-end;
}

.main-menu ul li {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style by classes instead tags

src/style.css Outdated
width: 100%;
height: 8px;
background-color: #00acdc;
bottom: -18.5px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bottom: -18.5px;
bottom: 0;

links shuld have height on full header height. so bottom shouldn't be hardcoded and should be 0.

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to pass all tests, don't hesitate to ask for some help in the chat

@sdoskich
Copy link
Author

Please, tell me what I have to do next.

@sdoskich sdoskich requested a review from etojeDenys December 24, 2024 13:22
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a thread in the mate chat and ping me there in comments, will try to help with those tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants