-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moyo header #5852
base: master
Are you sure you want to change the base?
Moyo header #5852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
[CODE: 10]
Additional info:
Files with too large content:
reports/html_report/index_bundle.js
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
[CODE: 10]
Additional info:
Files with too large content:
reports/html_report/index_bundle.js
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
The content size of the files in the pull request exceeds the limit. Please make sure that you do not add too many contents to the files (e.g., images, large text, etc.).
[CODE: 10]
Additional info:
Files with too large content:
reports/html_report/index_bundle.js
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
Too many changes in the pull request. Please make sure that you have added only the necessary changes to the pull request.
[CODE: 6]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo links is not correct.
Use demo links from readme.md file in project.
src/style.css
Outdated
justify-content: flex-end; | ||
} | ||
|
||
.main-menu ul li { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style by classes instead tags
src/style.css
Outdated
width: 100%; | ||
height: 8px; | ||
background-color: #00acdc; | ||
bottom: -18.5px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bottom: -18.5px; | |
bottom: 0; |
links shuld have height on full header height. so bottom shouldn't be hardcoded and should be 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to pass all tests, don't hesitate to ask for some help in the chat
Please, tell me what I have to do next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create a thread in the mate chat and ping me there in comments, will try to help with those tests
TEST REPORT LINK: https://github.com/sdoskich/layout_moyo-header/blob/master/reports/html_report/index.html
DEMO LINK: https://sdoskich.github.io/layout_moyo-header/