add task solution #5856

IlonaRuslanova · 2024-12-22T19:08:46Z

DEMO LINK
TEST REPORT LINK
Header height is set in 1 place (for the links)
Content is vertically centered (for any header height)
CSS is used to show all letters in Uppercase (don't type them in HTML)
Logo is an image wrapped with a link
CSS Variable is used for a blue color
Pseudo-element is used for a blue line below the active link
Code follows all the Code Style Rules ❗️

mateacademy-ai-mentor

Thank you for your hard work on this project! 🌟 While you've done a great job on many aspects, there are a few critical issues that need to be addressed before we can approve the pull request:

Navigation Links: All navigation links currently point to 'index.html'. If these links are intended to navigate to different sections or pages, you should update the 'href' attributes to the correct URLs. This is crucial for the functionality of the navigation menu.
CSS Attribute Selector: The selector [data-qa_hover] in your CSS file does not match the HTML attribute data-qa="hover". Please update the selector to [data-qa="hover"]::after to ensure the styles are applied correctly.

Once these issues are resolved, your code will be in great shape! Keep up the good work, and feel free to reach out if you need any help. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

  </head>
  <body>
    <h1>Moyo header</h1>
+    <header class="header">
+      <a
+        href="index.html"


All navigation links currently point to 'index.html'. If these links are intended to navigate to different sections or pages, you should update the 'href' attributes to the correct URLs.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

+        <ul class="nav__list">
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'apple' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'samsung' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'smartphones' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'laptops & computers' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'gadgets' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:37Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'tablets' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:38Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'photo' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:38Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


This link points to 'index.html'. Ensure this is the correct destination for the 'video' link. If not, update the 'href' attribute.

mateacademy-ai-mentor · 2024-12-22T19:09:38Z

src/style.css

+  left: 0;
+}
+
+[data-qa_hover]::after {


The selector '[data-qa_hover]' seems to be incorrect. In the HTML file, the attribute used is 'data-qa="hover"'. You should update the selector to '[data-qa="hover"]::after' to match the HTML attribute.

mateacademy-ai-mentor

Review Summary

Great progress on your project! 🎉 You've addressed several issues from the previous review, but there are still a few areas that need attention to ensure full functionality and adherence to best practices:

Navigation Links: All navigation links currently point to 'index.html'. If these links are meant to direct users to different sections or pages, please update them with the correct URLs to ensure proper navigation.
CSS Attribute Selector: You've successfully corrected the CSS selector to [data-qa="hover"]::after, which is great! This ensures that the styles are applied correctly.
CSS Variable for Blue Color: The blue color is still hardcoded as #00acdc. To improve maintainability, define a CSS variable for this color and use it throughout your CSS file.
HTML Formatting: Ensure your HTML formatting follows the guidelines, such as using 2 spaces for indentation and keeping lines within 80 characters.
Semantic Tags: Your use of semantic tags like <header>, <nav>, and <ul> is well done. Keep it up!
Logo Link: The logo is correctly implemented as a link with an image inside, which is excellent.
CSS Pseudo-element: The pseudo-element for the blue line below the active link is correctly implemented.

Overall, you've made significant progress. The decision to approve this pull request is to help you move forward with your learning journey. Please review the comments and address the issues to enhance your code quality. Keep up the great work, and remember to learn from these improvements! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

  </head>
  <body>
    <h1>Moyo header</h1>
+    <header class="header">
+      <a
+        href="index.html"


The href attribute for the logo link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+        <ul class="nav__list">
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'apple' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'samsung' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'smartphones' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'laptops & computers' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'gadgets' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'tablets' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:23Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'photo' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:24Z

src/index.html

+          </li>
+          <li class="nav__item">
+            <a
+              href="index.html"


The href attribute for the 'video' navigation link is set to 'index.html'. If this link is intended to navigate to a different page or section, update the URL accordingly.

mateacademy-ai-mentor · 2024-12-23T19:04:24Z

src/style.css

+.nav__link:hover {
+  color: #00acdc;
+}


Ensure that the CSS selector [data-qa_hover] matches the HTML attribute data-qa="hover". Update the selector to [data-qa="hover"]::after to ensure the styles are applied correctly.

add task solution

b3bbedd

mateacademy-ai-mentor suggested changes Dec 22, 2024

View reviewed changes

IlonaRuslanova added 2 commits December 23, 2024 19:43

add task solution

e607fff

1

a0044fb

IlonaRuslanova requested a review from mateacademy-ai-mentor December 23, 2024 19:03

mateacademy-ai-mentor approved these changes Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add task solution #5856

add task solution #5856

IlonaRuslanova commented Dec 22, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor Dec 22, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

mateacademy-ai-mentor Dec 23, 2024

add task solution #5856

Are you sure you want to change the base?

add task solution #5856

Conversation

IlonaRuslanova commented Dec 22, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment