-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #5859
base: master
Are you sure you want to change the base?
add task solution #5859
Conversation
Ditiselit
commented
Dec 23, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your submission! 🎉 Your code meets most of the task requirements, and you've done well with the semantic tags, CSS variables, and flexbox usage. However, there are a few areas for improvement:
- HTML Structure: Ensure each
<a>
tag is wrapped in its own<li>
element for semantic correctness and accessibility. - CSS Styling: Consider applying
text-transform: uppercase;
to specific elements rather than globally to allow for more flexible styling. - Flexbox Usage: Review the necessity of
display: flex;
on.nav__item
if each link is wrapped in a<li>
. - Attribute Usage: Verify the necessity and consistency of the
data-qa
attribute across the project.
These adjustments will enhance the functionality and maintainability of your code. Keep up the good work, and use this feedback to refine your skills further! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
> | ||
Apple | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
> | ||
Samsung | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
> | ||
Smartphones | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
> | ||
Laptops & Computers | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
> | ||
Gadgets | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
> | ||
Tablets | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
> | ||
Photo | ||
</a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each navigation link should be wrapped in a <li>
element to ensure semantic correctness and improve accessibility. Consider wrapping each <a>
tag within its own <li>
tag.
<a | ||
href="#" | ||
class="nav__link" | ||
data-qa="hover" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the data-qa
attribute is necessary and used correctly. If it's for testing purposes, make sure it's documented or used consistently across the project.
margin: 0; | ||
} | ||
|
||
.nav__item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .nav__item
class uses display: flex;
, which might not be necessary if each navigation link is wrapped in its own <li>
element. Consider reviewing the HTML structure to ensure semantic correctness and potentially simplify the CSS.
font-family: Roboto, sans-serif; | ||
font-style: normal; | ||
line-height: normal; | ||
font-size: 12px; | ||
font-weight: 500; | ||
text-transform: uppercase; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying text-transform: uppercase;
globally to the html
element might be too restrictive. Consider applying this style to specific elements that require uppercase text to allow for more flexible text styling across the site.