Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added code html and styles #5861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added code html and styles #5861

wants to merge 1 commit into from

Conversation

Bukavyna
Copy link

@Bukavyna Bukavyna commented Dec 23, 2024 •
edited
Loading

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Dec 23, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your submission! 🎉 The HTML and CSS files are well-structured and meet most of the task requirements. There are a few minor issues, such as ensuring the h1 tag is appropriately placed and setting the height for nav links, but these do not critically impact the functionality. Keep up the good work and consider addressing these minor points for even better code quality in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

etojeDenys
etojeDenys suggested changes Dec 24, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your demo links don't work, pls, feel free to ask for some help how to fix them in the chat

@Bukavyna
Copy link
Author

https://github.com/Bukavyna/layout_moyo-header/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys requested changes

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bukavyna @etojeDenys @mateacademy-ai-mentor