add task solution #5927
add task solution #5927
Conversation
There was a problem hiding this comment.
It looks like there are a couple of critical issues that need to be addressed before we can approve the Pull Request. The use of a CSS variable for the blue color is missing, and there's a duplicate pseudo-element definition that could lead to confusion. Additionally, there's a typo in the class name that should be corrected for clarity. Once these are fixed, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| </a> | ||
|
|
||
| <nav class="nav"> | ||
| <ul class="nav__lissing"> |
There was a problem hiding this comment.
There seems to be a typo in the class name 'nav__lissing'. It should likely be 'nav__listing' to better reflect its purpose as a navigation list.
src/style.css
Outdated
| font-weight: 500; | ||
| } | ||
|
|
||
| .nav__lissing { |
There was a problem hiding this comment.
The class name '.nav__lissing' contains a typo. It should likely be '.nav__listing' to match the intended purpose and the HTML file.
src/style.css
Outdated
| .is-active ::after { | ||
| content: ''; | ||
| position: absolute; | ||
| bottom: 0; | ||
| left: 0; | ||
| width: 100%; | ||
| height: 2px; | ||
| background-color: #00acdc; | ||
| } |
There was a problem hiding this comment.
The selector '.is-active ::after' seems redundant and potentially conflicts with '.nav__link.is-active::after'. Consider removing or consolidating these styles to avoid confusion and ensure consistency.
No description provided.