-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop #4861
base: master
Are you sure you want to change the base?
develop #4861
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
.card { | ||
border: 1px solid $color-gray; | ||
width: 200px; | ||
padding: 32px 16px 16px; | ||
|
||
&__description { | ||
color: $text-main-color; | ||
font-size: 12px; | ||
font-weight: 500; | ||
line-height: 18px; | ||
margin-bottom: 4px; | ||
} | ||
&__code { | ||
color: $text-secondary-color; | ||
font-size: 10px; | ||
line-height: 14px; | ||
} | ||
|
||
&__reviews { | ||
color: $text-main-color; | ||
font-size: 10px; | ||
line-height: 14px; | ||
} | ||
|
||
&__stars { | ||
display: flex; | ||
align-items: center; | ||
justify-content: space-between; | ||
margin-bottom: 24px; | ||
margin-top: 16px; | ||
} | ||
|
||
&__img { | ||
display: block; | ||
width: 160px; | ||
height: 134px; | ||
margin: 0 auto 40px; | ||
} | ||
|
||
&__cost { | ||
display: flex; | ||
justify-content: space-between; | ||
margin-bottom: 16px; | ||
} | ||
&__price { | ||
color: $text-secondary-color; | ||
font-size: 12px; | ||
line-height: 18px; | ||
} | ||
&__total { | ||
color: $text-main-color; | ||
line-height: 18px; | ||
font-weight: 700; | ||
} | ||
|
||
&__button { | ||
height: 40px; | ||
width: 100%; | ||
border-radius: 5px; | ||
font-size: 14px; | ||
background-color: #00acdc; | ||
color: #fff; | ||
box-sizing: border-box; | ||
border: 1px solid #00acdc; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You have a variable for this color, don't forget to use it |
||
|
||
&:hover { | ||
color: $color-blue-accent; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The color value for the hover state is using a variable ($color-blue-accent), which is good for consistency. However, ensure that this variable is defined in your variables file. If it's not, this could lead to unexpected results. |
||
background-color: $color-white; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The background-color value for the hover state is using a variable ($color-white), which is good for consistency. However, ensure that this variable is defined in your variables file. If it's not, this could lead to unexpected results. |
||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
.stars { | ||
display: flex; | ||
|
||
&__star { | ||
width: 16px; | ||
height: 16px; | ||
margin-left: 4px; | ||
background-position: center; | ||
background-repeat: no-repeat; | ||
background-image: url('../images/star.svg'); | ||
} | ||
|
||
&__star:first-child { | ||
margin-left: 0; | ||
} | ||
|
||
@for $i from 0 through 5 { | ||
&--#{$i} { | ||
.stars__star:nth-child(-n + #{$i}) { | ||
background-image: url('../images/star-active.svg'); | ||
} | ||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,17 @@ | ||
body { | ||
@import '../utils/variables'; | ||
@import './reset.css'; | ||
@import './blocks/card'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to the Code Style Rules, we should use SCSS files as imports. So, you should convert your reset.css file to SCSS format and import it as a SCSS file. |
||
@import './blocks/stars'; | ||
|
||
html { | ||
font-family: Roboto, sans-serif; | ||
font-weight: 400; | ||
} | ||
|
||
p { | ||
margin: 0; | ||
} | ||
|
||
* { | ||
box-sizing: border-box; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href attribute is linking to a SCSS file. HTML files should link to CSS files instead. Please compile your SCSS to CSS and link to the resulting CSS file.