add task solution #4875
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,85 @@ | ||
| <!doctype html> | ||
| <html | ||
| lang="en" | ||
| class="page" | ||
| > | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta | ||
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0" | ||
| /> | ||
| <title>Product cards</title> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.googleapis.com" | ||
| /> | ||
| <link | ||
| rel="preconnect" | ||
| href="https://fonts.gstatic.com" | ||
| /> | ||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" | ||
| rel="stylesheet" | ||
| /> | ||
| <link | ||
| rel="stylesheet" | ||
| href="./styles/index.scss" | ||
| /> | ||
| </head> | ||
| <body class="page__budy"> | ||
| <div | ||
| class="card" | ||
| data-qa="card" | ||
| > | ||
| <img | ||
| src="/src/images/imac.jpeg" | ||
| alt="prodact img" | ||
|
There was a problem hiding this comment. There is a typo in the alt attribute. It should be 'product img' instead of 'prodact img'. There was a problem hiding this comment. alt attribute should describe the image content |
||
| class="card__image" | ||
| /> | ||
| <div class="card__product-title"> | ||
| <h2 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h2> | ||
|
|
||
| <h3 class="card__code">Product code: 195434</h3> | ||
| </div> | ||
|
|
||
| <div class="card__product-code"></div> | ||
|
|
||
| <div class="card__reviews"> | ||
| <div class="stars stars--4"> | ||
| <div class="stars__star"></div> | ||
|
|
||
| <div class="stars__star"></div> | ||
|
|
||
| <div class="stars__star"></div> | ||
|
|
||
| <div class="stars__star"></div> | ||
|
|
||
| <div class="stars__star"></div> | ||
| </div> | ||
|
|
||
| <div> | ||
| <span class="card__reviw">Reviews: 5</span> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="card__price"> | ||
| <span class="card__price-text">Price:</span> | ||
| <span class="card__price-value">$2,199</span> | ||
| </div> | ||
|
|
||
| <div> | ||
|
|
||
| <a | ||
| href="#" | ||
| class="card__button" | ||
| data-qa="hover" | ||
| > | ||
| Buy | ||
| </a> | ||
| </div> | ||
| <section></section> | ||
| </div> | ||
| </body> | ||
| </html> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| .card { | ||
| width: 200px; | ||
|
|
||
| @include flex('', ''); | ||
|
There was a problem hiding this comment. Why do you path two empty strings to flex mixin? It looks strange |
||
|
|
||
| flex-direction: column; | ||
| border: 1px solid $card-border-color; | ||
| border-radius: 5px; | ||
| background-color: $card-bg-color; | ||
|
|
||
| &__image { | ||
| margin: 32px 19px 40px; | ||
| width: 160px; | ||
| height: 134px; | ||
| } | ||
|
|
||
| &__product-title { | ||
| margin: 0 16px; | ||
|
There was a problem hiding this comment. You should set padding to the card instead, so it would be easier to control. |
||
| padding: 0; | ||
| } | ||
|
|
||
| &__title { | ||
| @include flex(center, ''); | ||
| @include font(12px, 500, 18px); | ||
|
|
||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| &__code { | ||
| @include font(10px, 400, 14px); | ||
|
|
||
| color: $text-secondary-color; | ||
| margin-top: 4px; | ||
| margin-bottom: 0; | ||
| } | ||
|
|
||
| &__reviews { | ||
| @include flex(center, space-between); | ||
|
|
||
| height: 16px; | ||
| margin: 16px 16px 0; | ||
| } | ||
|
|
||
| &__reviw { | ||
| @include font(10px, 400, 14px); | ||
|
|
||
| display: flex; | ||
| } | ||
|
|
||
| &__price { | ||
| @include flex('center', space-between); | ||
|
|
||
| margin: 24px 16px 0; | ||
| } | ||
|
|
||
| &__price-text { | ||
| @include font(12px, 400, 18px); | ||
|
|
||
| color: $text-secondary-color; | ||
| } | ||
|
|
||
| &__price-value { | ||
| @include font(16px, 700, 18px); | ||
|
|
||
| color: $text-main-color; | ||
| } | ||
|
|
||
| &__button { | ||
| @include flex(center, ''); | ||
| @include font(14px, 700, 16px); | ||
|
|
||
| width: 166px; | ||
|
There was a problem hiding this comment. Don't hardcode width, it should fit all space |
||
| height: 40px; | ||
| margin: 16px; | ||
| padding: 12px 70px 12px 69px; | ||
|
There was a problem hiding this comment. If would be more text in the button it wouldn't fit |
||
| border-radius: 5px; | ||
| border: 1px solid $button-border-color; | ||
| background-color: $button-bg-color; | ||
| text-transform: uppercase; | ||
| text-decoration: none; | ||
| color: $text-white-color; | ||
|
|
||
| &:hover { | ||
| background-color: $text-white-color; | ||
| color: $button-bg-color; | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .page { | ||
| &__budy { | ||
| margin: 0; | ||
| padding: 0; | ||
| font-family: Roboto, sans-serif; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| .stars { | ||
| @include flex(center, ''); | ||
|
|
||
| &__star { | ||
| width: 16px; | ||
| height: 16px; | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| background-image: url(/src/images/star.svg); | ||
| } | ||
|
|
||
| &__star:not(:last-child) { | ||
| margin-right: 4px; | ||
| } | ||
|
|
||
| &.stars--4 .stars__star:nth-child(-n + 4) { | ||
|
There was a problem hiding this comment. It should be the same as in the stars task, if the modifier is |
||
| background-image: url(/src/images/star-active.svg); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| @import './utils/variable'; | ||
| @import './utils/mixin'; | ||
| @import './blocks/page'; | ||
| @import './blocks/card'; | ||
| @import './blocks/stars'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| @mixin flex($align, $justify) { | ||
| display: flex; | ||
| align-items: $align; | ||
| justify-content: $justify; | ||
| } | ||
|
|
||
| @mixin font($size, $weight: 400, $height: normal, $style: normal) { | ||
| font-size: $size; | ||
| line-height: $height; | ||
| font-weight: $weight; | ||
| font-style: $style; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| $text-main-color: #060b35; | ||
| $text-secondary-color: #616070; | ||
| $text-white-color: #fff; | ||
| $card-bg-color: #fff; | ||
| $button-bg-color: #00acdc; | ||
| $card-border-color: #f3f3f3; | ||
| $button-border-color: #00acdc; |
|
There was a problem hiding this comment. This and variables files are duplicated |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| @mixin flex($align, $justify) { | ||
| display: flex; | ||
| align-items: $align; | ||
| justify-content: $justify; | ||
| } | ||
|
|
||
| @mixin font($size, $weight: 400, $height: normal, $style: normal) { | ||
| font-size: $size; | ||
| line-height: $height; | ||
| font-weight: $weight; | ||
| font-style: $style; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| $text-main-color: #060b35; | ||
| $text-secondary-color: #616070; | ||
| $text-white-color: #fff; | ||
| $card-bg-color: #fff; | ||
| $button-bg-color: #00acdc; | ||
| $card-border-color: #f3f3f3; | ||
| $button-border-color: #00acdc; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stylesheet link should point to a CSS file, not an SCSS file. SCSS files need to be compiled to CSS before they can be linked in HTML.