-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card #4876
base: master
Are you sure you want to change the base?
Card #4876
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
body { | ||
margin: 0; | ||
font-family: Roboto, sans-serif, Arial; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The font-family property should list generic font families at the end. Consider placing 'Arial' before 'sans-serif'. |
||
} | ||
|
||
.card { | ||
width: 200px; | ||
padding: 32px 16px 16px; | ||
} | ||
|
||
.card_image { | ||
display: flex; | ||
width: 160px; | ||
height: 134px; | ||
margin-bottom: 40px; | ||
} | ||
|
||
.description { | ||
font-weight: 500; | ||
margin-bottom: 4px; | ||
font-size: 12px; | ||
} | ||
|
||
.card_image--imac { | ||
background-image: url(../images/imac.jpeg); | ||
} | ||
|
||
.product_code { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.product_code' to '.product-code'. |
||
margin-bottom: 16px; | ||
font-size: 10px; | ||
line-height: 14px; | ||
} | ||
|
||
.star_review { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.star_review' to '.star-review'. |
||
margin-bottom: 24px; | ||
display: flex; | ||
justify-content: space-between; | ||
} | ||
|
||
.reviews { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.reviews' to '.review'. |
||
display: flex; | ||
white-space: nowrap; | ||
font-size: 10px; | ||
align-items: center; | ||
} | ||
|
||
.stars_active { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.stars_active' to '.stars-active'. |
||
background-image: url(../images/star-active.svg); | ||
background-repeat: no-repeat; | ||
background-position: center; | ||
width: 16px; | ||
height: 16px; | ||
margin-right: 4px; | ||
} | ||
|
||
.stars { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.stars' to '.star'. |
||
background-image: url(../images/star.svg); | ||
background-repeat: no-repeat; | ||
background-position: center; | ||
width: 16px; | ||
height: 16px; | ||
margin-right: 4px; | ||
} | ||
|
||
.price { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.price' to '.pricing'. |
||
display: flex; | ||
justify-content: space-between; | ||
margin-bottom: 16px; | ||
} | ||
|
||
.text_price { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.text_price' to '.text-price'. |
||
color: #616070; | ||
} | ||
|
||
.numeric_price { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.numeric_price' to '.numeric-price'. |
||
font-family: Roboto, sans-serif, Arial; | ||
font-weight: 700; | ||
} | ||
|
||
.button_buy { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Class names should use hyphens instead of underscores according to the BEM naming convention. Consider renaming '.button_buy' to '.button-buy'. |
||
display: flex; | ||
justify-content: center; | ||
align-items: center; | ||
background-color: #00acdc; | ||
color: white; | ||
border-radius: 5px; | ||
width: 100%; | ||
height: 40px; | ||
border: solid #00acdc; | ||
} | ||
|
||
.button_buy:hover { | ||
background-color: white; | ||
color: #00acdc; | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like you have multiple divs with the class 'stars_active'. If these are meant to represent individual stars in a rating system, consider using a more semantic approach, such as using a list or a span with appropriate ARIA attributes for better accessibility.