-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4877
base: master
Are you sure you want to change the base?
add task solution #4877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's a small issue with linking the SCSS file directly instead of the compiled CSS file. Please update the link to point to the correct CSS file. Keep up the great work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500;700&display=swap" | ||
rel="stylesheet" | ||
/> | ||
|
||
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The href attribute in the link tag should point to a CSS file, not an SCSS file. Ensure the compiled CSS file is linked here instead of the SCSS source file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on maintaining a well-structured and semantic HTML and SCSS! 🎉 Just a small reminder to ensure consistent use of BEM modifiers like .stars--1
, .stars--2
, etc., with the base class .stars
. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
.stars--1 .stars__star:nth-child(-n + 1), | ||
.stars--2 .stars__star:nth-child(-n + 2), | ||
.stars--3 .stars__star:nth-child(-n + 3), | ||
.stars--4 .stars__star:nth-child(-n + 4), | ||
.stars--5 .stars__star:nth-child(-n + 5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of .stars--1
, .stars--2
, etc., suggests a BEM modifier pattern. Ensure that these classes are used consistently throughout your HTML and CSS to maintain the BEM methodology. If these are intended to be modifiers, they should be used in conjunction with the base class .stars
.
-DEMO LINK