-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #4882
Open
kripikripi
wants to merge
4
commits into
mate-academy:master
Choose a base branch
from
kripikripi:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
solution #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrinko
requested changes
Oct 19, 2024
src/index.html
Outdated
Comment on lines
29
to
66
<div | ||
class="card" | ||
data-qa="card" | ||
> | ||
<img | ||
src="../src/images/imac.jpeg" | ||
alt="imac" | ||
class="card__image" | ||
/> | ||
<main class="card__content"> | ||
<h2 class="card__title"> | ||
APPLE A1419 iMac 27" Retina | ||
<br /> | ||
5K Monoblock (MNED2UA/A) | ||
</h2> | ||
<span class="card__code">Product code: 195434</span> | ||
<div class="card__review"> | ||
<div class="stars stars--4"> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
<span>Reviews: 5</span> | ||
</div> | ||
<div class="card__price"> | ||
<span class="card__pricetext">Price:</span> | ||
<span class="card__pricevalue">$2,199</span> | ||
</div> | ||
<button | ||
data-qa="hover" | ||
class="card__button" | ||
> | ||
BUY | ||
</button> | ||
</main> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я б форматував так
Suggested change
<div | |
class="card" | |
data-qa="card" | |
> | |
<img | |
src="../src/images/imac.jpeg" | |
alt="imac" | |
class="card__image" | |
/> | |
<main class="card__content"> | |
<h2 class="card__title"> | |
APPLE A1419 iMac 27" Retina | |
<br /> | |
5K Monoblock (MNED2UA/A) | |
</h2> | |
<span class="card__code">Product code: 195434</span> | |
<div class="card__review"> | |
<div class="stars stars--4"> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
</div> | |
<span>Reviews: 5</span> | |
</div> | |
<div class="card__price"> | |
<span class="card__pricetext">Price:</span> | |
<span class="card__pricevalue">$2,199</span> | |
</div> | |
<button | |
data-qa="hover" | |
class="card__button" | |
> | |
BUY | |
</button> | |
</main> | |
</div> | |
<div class="card" data-qa="card"> | |
<img | |
src="../src/images/imac.jpeg" | |
alt="imac" | |
class="card__image" | |
/> | |
<main class="card__content"> | |
<h2 class="card__title"> | |
APPLE A1419 iMac 27" Retina | |
<br /> | |
5K Monoblock (MNED2UA/A) | |
</h2> | |
<span class="card__code">Product code: 195434</span> | |
<div class="card__review"> | |
<div class="stars stars--4"> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
<div class="stars__star"></div> | |
</div> | |
<span>Reviews: 5</span> | |
</div> | |
<div class="card__price"> | |
<span class="card__pricetext">Price:</span> | |
<span class="card__pricevalue">$2,199</span> | |
</div> | |
<button | |
data-qa="hover" | |
class="card__button" | |
> | |
BUY | |
</button> | |
</main> | |
</div> |
<br /> | ||
5K Monoblock (MNED2UA/A) | ||
</h2> | ||
<span class="card__code">Product code: 195434</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Це завершений шматок інформації
тож семантично це параграф
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in it own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️