Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #4882

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

solution #4882

wants to merge 4 commits into from

Conversation

kripikripi
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in it own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

src/index.html Outdated
Comment on lines 29 to 66
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
alt="imac"
class="card__image"
/>
<main class="card__content">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</h2>
<span class="card__code">Product code: 195434</span>
<div class="card__review">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span>Reviews: 5</span>
</div>
<div class="card__price">
<span class="card__pricetext">Price:</span>
<span class="card__pricevalue">$2,199</span>
</div>
<button
data-qa="hover"
class="card__button"
>
BUY
</button>
</main>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я б форматував так

Suggested change
<div
class="card"
data-qa="card"
>
<img
src="../src/images/imac.jpeg"
alt="imac"
class="card__image"
/>
<main class="card__content">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</h2>
<span class="card__code">Product code: 195434</span>
<div class="card__review">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span>Reviews: 5</span>
</div>
<div class="card__price">
<span class="card__pricetext">Price:</span>
<span class="card__pricevalue">$2,199</span>
</div>
<button
data-qa="hover"
class="card__button"
>
BUY
</button>
</main>
</div>
<div class="card" data-qa="card">
<img
src="../src/images/imac.jpeg"
alt="imac"
class="card__image"
/>
<main class="card__content">
<h2 class="card__title">
APPLE A1419 iMac 27" Retina
<br />
5K Monoblock (MNED2UA/A)
</h2>
<span class="card__code">Product code: 195434</span>
<div class="card__review">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<span>Reviews: 5</span>
</div>
<div class="card__price">
<span class="card__pricetext">Price:</span>
<span class="card__pricevalue">$2,199</span>
</div>
<button
data-qa="hover"
class="card__button"
>
BUY
</button>
</main>
</div>

<br />
5K Monoblock (MNED2UA/A)
</h2>
<span class="card__code">Product code: 195434</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Це завершений шматок інформації
тож семантично це параграф

src/index.html Outdated Show resolved Hide resolved
src/styles/index.scss Outdated Show resolved Hide resolved
src/styles/index.scss Outdated Show resolved Hide resolved
src/styles/index.scss Outdated Show resolved Hide resolved
src/styles/index.scss Outdated Show resolved Hide resolved
src/styles/index.scss Outdated Show resolved Hide resolved
src/styles/index.scss Show resolved Hide resolved
src/styles/stars.scss Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants