Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add solution #4886

Closed
wants to merge 3 commits into from
Closed

add solution #4886

wants to merge 3 commits into from

Conversation

LiliiaVol
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Oct 17, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on structuring your SCSS file! 🎉 Just a couple of minor tweaks needed: ensure your <a> tags have href attributes, and update the link to point to a CSS file instead of SCSS. Keep up the good work!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/index.html
@@ -11,8 +11,61 @@
rel="stylesheet"
href="./styles/index.scss"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute should link to a CSS file, not a SCSS file. Please change './styles/index.scss' to './styles/index.css'.

src/index.html
<a
class="container__button"
data-qa="hover"
>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag should have an href attribute to be a valid link. If it's meant to be a button, consider using a element instead.

@LiliiaVol
Copy link
Author

  • DEMO LINK
  • TEST REPORT LINK
  • there 2 BEM blocks card and stars each in it own file
  • SCSS Nesting is used for elements, modifiers and pseudo-classes
  • SCSS Variables are used for main values and placed in a separate file
  • all stars--N modifiers work as expected (Highlight first N stars)
  • Code follows all the Code Style Rules ❗️

@LiliiaVol LiliiaVol closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor Awaiting requested review from mateacademy-ai-mentor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiliiaVol @mateacademy-ai-mentor