Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product card #4891

Closed
wants to merge 1 commit into from
Closed

product card #4891

wants to merge 1 commit into from

Conversation

StricTGod
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in it own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few critical issues that need to be addressed before we can proceed. The use of SCSS in the href attribute is problematic as browsers require compiled CSS files. Additionally, ensure that placeholder links are replaced with valid URLs. Once these are fixed, you'll be all set! Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<link
rel="stylesheet"
href="./styles/index.scss"
href="/src/styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is pointing to a SCSS file. Typically, browsers cannot directly interpret SCSS files. You should link to a compiled CSS file instead.

data-qa="hover"
>
<a
href="#"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute of the anchor tag is set to '#'. This is generally used as a placeholder and should be replaced with a valid URL or removed if not needed.

border-radius: 0.5px;
}

&__star:nth-child(-n + 4) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector &__star:nth-child(-n + 4) might not be clear in terms of its intent. Consider adding a comment to explain that it targets the first four child elements, or use a more descriptive class name if possible.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's a critical issue with linking to a SCSS file instead of a compiled CSS file. Please update the link to point to the correct CSS file. Once that's done, your code will be good to go! 😊 Keep up the great work!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<link
rel="stylesheet"
href="./styles/index.scss"
href="/src/styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute should link to a CSS file, not a SCSS file. Browsers cannot directly interpret SCSS files, so you need to compile your SCSS into CSS and link to the resulting CSS file.

@StricTGod StricTGod closed this by deleting the head repository Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants