Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4907

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add task solution #4907

wants to merge 2 commits into from

Conversation

IlMarauder
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in it own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few issues that need to be addressed before we can approve this PR. The missing unit for the 'font-size' property and incorrect paths for imports and background images are critical for ensuring the functionality and correctness of the code. Please make these adjustments, and you'll be all set! Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


.image {
display: flex;
background-image: url(/src/images/imac.jpeg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL for the background image seems incorrect. Ensure the path is correct relative to the CSS file location. It should be './images/imac.jpeg' if the image is in the 'images' folder within the 'src' directory.

margin-top: 16px;
align-items: flex-end;

@import '/src/styles/blocks/stars';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for '/src/styles/blocks/stars' seems incorrect. Ensure the path is correct relative to the current file location. It should be './blocks/stars' if the 'stars' file is in the 'blocks' folder within the 'styles' directory.


&__title {
font-weight: 400;
font-size: 12;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'font-size' property value should include a unit (e.g., 'px', 'em'). It seems to be missing here.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on defining the SCSS variables! 🎉 While there are a few issues, such as missing units for font-size, an import statement inside a CSS rule, and a potentially incorrect file path for a background image, these are excellent learning opportunities. Please review the comments to improve your code. Remember, addressing these issues will help you grow as a developer. Keep up the good work and continue learning from your experiences!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


.image {
display: flex;
background-image: url(/src/images/imac.jpeg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file path in the background-image URL seems incorrect. Ensure the path is correct and points to an existing image file.

margin-top: 16px;
align-items: flex-end;

@import '/src/styles/blocks/stars';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for '/src/styles/blocks/stars' should not be inside a CSS rule. Consider moving it to the top of the file or outside any CSS rules.


&__title {
font-weight: 400;
font-size: 12;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font-size value should have a unit (e.g., 'px', 'em'). Currently, it is missing a unit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants