add task solution #4910
add task solution #4910
Conversation
thshnhta
commented
Oct 21, 2024
thshnhta
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job! 🎉 The code is functional and meets the requirements. While there are some suggestions regarding BEM naming conventions, they are minor and do not affect the functionality. Keep up the good work and consider these suggestions for future improvements!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| border-radius: $border-radius; | ||
| background-color: #fff; | ||
|
|
||
| &__image { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-image instead of &__image. Consider changing this to maintain consistency with BEM.
| margin-bottom: 40px; | ||
| } | ||
|
|
||
| &__title { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-title instead of &__title. Consider changing this to maintain consistency with BEM.
| margin-bottom: 4px; | ||
| } | ||
|
|
||
| &__product-code { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-product-code instead of &__product-code. Consider changing this to maintain consistency with BEM.
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| &__reviews { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-reviews instead of &__reviews. Consider changing this to maintain consistency with BEM.
| margin-bottom: 24px; | ||
| } | ||
|
|
||
| &__reviews-count { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-reviews-count instead of &__reviews-count. Consider changing this to maintain consistency with BEM.
| text-align: right; | ||
| } | ||
|
|
||
| &__price { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-price instead of &__price. Consider changing this to maintain consistency with BEM.
| margin-bottom: 16px; | ||
| } | ||
|
|
||
| &__price-text { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-price-text instead of &__price-text. Consider changing this to maintain consistency with BEM.
| font-weight: 400; | ||
| } | ||
|
|
||
| &__price-value { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-price-value instead of &__price-value. Consider changing this to maintain consistency with BEM.
| color: $main-text-color; | ||
| } | ||
|
|
||
| &__button { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-button instead of &__button. Consider changing this to maintain consistency with BEM.
| transition: all 0.2s ease; | ||
| } | ||
|
|
||
| &__button:hover { |
There was a problem hiding this comment.
The BEM naming convention suggests using a single underscore for element names, like &-button:hover instead of &__button:hover. Consider changing this to maintain consistency with BEM.
