Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4915

Closed
wants to merge 1 commit into from
Closed

add task solution #4915

wants to merge 1 commit into from

Conversation

d1nexl
Copy link

@d1nexl d1nexl commented Oct 22, 2024

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is a critical issue with the background-image URL not meeting the task requirements, which needs to be addressed. Please adjust the path to be relative to the index.scss file as specified. Keep up the great work, and once this is fixed, your implementation will be spot on! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

>
<img
class="card__image"
src="/src/images/imac.jpeg"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source should be relative to the SCSS file as per the task requirement: 'background-image: url() should be relative to the index.scss'. Ensure the path is correct if this is intended for a background image.

}

.stars__star {
background-image: url(/src/images/star.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background-image URL should be relative to the index.scss file. According to the task requirements, it should start with ../images instead of /src/images【8:2†description.md】.

}

.stars--4 .stars__star:nth-child(-n + 4) {
background-image: url(/src/images/star-active.svg);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background-image URL for the active stars should also be relative to the index.scss file. Ensure it starts with ../images as per the task requirements【8:2†description.md】.

@d1nexl d1nexl closed this by deleting the head repository Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants