Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search bar #4494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

search bar #4494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ ___

❗️ Replace `<your_account>` with your Github username and copy the links to `Pull Request` description:

- [DEMO LINK](https://<your_account>.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_search-bar-airbnb/report/html_report/)
- [DEMO LINK](https://skrudj98.github.io/layout_search-bar-airbnb/)
- [TEST REPORT LINK](https://skrudj98.github.io/layout_search-bar-airbnb/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

- [ ] Icon implemented using background-image CSS property
- [ ] Inputs are written inside of 'form' tag with correctly passed attributes
- [ ] All `Typical Mistakes` from `BEM` lesson theory are checked.
- [ ] Code follows all the [Code Style Rules ❗️](./checklist.md)
- [х] Icon implemented using background-image CSS property
- [х] Inputs are written inside of 'form' tag with correctly passed attributes
- [х] All `Typical Mistakes` from `BEM` lesson theory are checked.
- [х] Code follows all the [Code Style Rules ❗️](./checklist.md)
24 changes: 20 additions & 4 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,35 @@
<title>Document</title>
<link
rel="stylesheet"
href="style.css"
href="styles/style.css"
Comment on lines 14 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes for the link tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.

/>
<link
rel="preconnect"
href="https://fonts.googleapis.com"
/>
<link
rel="preconnect"
href="https://fonts.gstatic.com"
crossorigin="anonymous"
/>
<link
href="https://fonts.googleapis.com/css2?family=Sen:[email protected]&display=swap"
rel="stylesheet"
Comment on lines +27 to +29
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes for the link tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.

/>
</head>
<body>
<body class="search">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class attribute value should represent the meaning of the content, not the styles or tag names. Please ensure that the class name 'search' accurately represents the content of the body element.

<input
class="search__big search__big-img"
type="text"
data-qa="keypress"
data-qa="keypress big"
placeholder="Try “Los Angeles“"
name="big"
Comment on lines 33 to +38
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes for the input tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.

/>

<input
class="search__small search__small-img"
type="text"
data-qa="hover"
data-qa="hover small"
placeholder="Try “Los Angeles“"
Comment on lines 41 to 45
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attributes for the input tag should start on a new line with 2-space indentation related to the tag, as per the checklist for keeping attributes correctly formatted.

/>
</body>
Expand Down
1 change: 0 additions & 1 deletion src/style.css
View file
Open in desktop

This file was deleted.

Loading