-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4542
base: master
Are you sure you want to change the base?
add task solution #4542
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,16 +17,23 @@ | |
/> | ||
</head> | ||
<body> | ||
<input | ||
type="text" | ||
data-qa="keypress" | ||
placeholder="Try “Los Angeles“" | ||
/> | ||
<form | ||
action="submit" | ||
class="form" | ||
> | ||
<input | ||
type="text" | ||
data-qa="big" | ||
placeholder="Try “Los Angeles“" | ||
class="form__input form__input_big" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
/> | ||
Comment on lines
+24
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
|
||
<input | ||
type="text" | ||
data-qa="hover" | ||
placeholder="Try “Los Angeles“" | ||
/> | ||
<input | ||
type="text" | ||
data-qa="small" | ||
placeholder="Try “Los Angeles“" | ||
class="form__input form__input_small" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
/> | ||
Comment on lines
+31
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The value of the |
||
</form> | ||
Comment on lines
+20
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your form lacks a submit button. Even though it's not explicitly stated in the task, it's a good practice to include one in your form. Without it, users won't be able to submit the form. |
||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,70 @@ | ||
/* add styles here */ | ||
@font-face { | ||
font-family: Avenir; | ||
src: | ||
url('fonts/Avenir.ttc') format('truetype'), | ||
url('fonts/Avenir-Book.ttf') format('truetype'), | ||
url('fonts/Avenir-Heavy.ttf') format('truetype'); | ||
} | ||
|
||
body { | ||
padding: 0; | ||
margin: 0; | ||
|
||
font-family: Avenir, Arial, Helvetica, sans-serif; | ||
font-weight: 300; | ||
color: #3d4e61; | ||
} | ||
|
||
.form { | ||
padding: 20px 8px; | ||
} | ||
|
||
.form__input { | ||
display: block; | ||
box-sizing: border-box; | ||
width: 100%; | ||
font-family: inherit; | ||
background-image: url(images/Search.svg); | ||
background-repeat: no-repeat; | ||
border: 1px solid #e1e7ed; | ||
border-radius: 5px; | ||
box-shadow: 0 1px 8px 0 #3d4e611a; | ||
} | ||
|
||
.form__input:hover { | ||
border: 1px solid #e1e7ed; | ||
box-shadow: 0 3px 8px 0 #3d4e6133; | ||
} | ||
|
||
.form__input:focus { | ||
outline: none; | ||
background-color: linear-gradient(180deg, #fff 0%, #f6f6f7 100%); | ||
box-shadow: none; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
} | ||
|
||
.form__input:active { | ||
background-color: linear-gradient(180deg, #fff 0%, #f6f6f7 100%); | ||
box-shadow: none; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same issue here, the |
||
} | ||
|
||
.form__input_big { | ||
height: 70px; | ||
margin-bottom: 20px; | ||
font-size: 16px; | ||
background-position: 25px; | ||
background-size: 19px 19px; | ||
padding-left: 62px; | ||
} | ||
|
||
.form__input_small { | ||
height: 42px; | ||
font-size: 14px; | ||
background-position: 13px; | ||
background-size: 11px 11px; | ||
padding-left: 33px; | ||
} | ||
|
||
.form__input::placeholder { | ||
font-family: Avenir, Arial, Helvetica, sans-serif; | ||
font-weight: 400; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
action
attribute of the form tag is supposed to contain the URL where the form data is sent to. In your case,submit
is not a valid URL. If you don't have a specific URL to send the form data to, you can just leave this attribute out.