add task solution #4669
add task solution #4669
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 While your code meets many of the task requirements, there's a critical issue with the HTML forms that needs to be addressed before we can approve the pull request. The <form> tags are self-closing, which is incorrect in HTML. This affects the functionality of the forms, as they need both opening and closing tags to properly encapsulate their contents. Please correct this issue to ensure the forms work as expected. Once you've made these changes, feel free to resubmit, and I'll be happy to review it again. Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| <form | ||
| class="search-bar" | ||
| data-qa="big" | ||
| > |
There was a problem hiding this comment.
The <form> tag is incorrectly self-closing. In HTML, <form> elements should have both opening and closing tags to properly contain their child elements. Change <form /> to <form> and ensure it has a corresponding </form> tag.
src/index.html
Outdated
| <form | ||
| class="search-bar" | ||
| data-qa="small" | ||
| > |
There was a problem hiding this comment.
Similar to the previous form, this <form> tag is incorrectly self-closing. Ensure that it has both opening and closing tags to properly encapsulate the input element. Change <form /> to <form> and ensure it has a corresponding </form> tag.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: 7]
If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Review Summary
Great job on addressing the previous issues with the HTML forms! 🎉 The <form> tags are now correctly implemented with both opening and closing tags, ensuring that the forms function as expected. Your CSS file is well-structured and effectively applies styles to the elements, with no critical issues found.
While the main issue with the HTML forms has been resolved, remember to always ensure that your HTML tags are properly opened and closed to avoid any functionality problems. This attention to detail is crucial for developing robust web applications.
Keep up the good work, and continue to learn from these experiences. Addressing such issues will help you improve your coding skills and produce even better solutions in the future. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <form | ||
| class="search-bar" | ||
| data-qa="big"> |
There was a problem hiding this comment.
The <form> tag is incorrectly self-closing. It should have a separate closing tag </form> after the input element to properly encapsulate its contents.
| <form | ||
| class="search-bar" | ||
| data-qa="small"> |
There was a problem hiding this comment.
The <form> tag is incorrectly self-closing. It should have a separate closing tag </form> after the input element to properly encapsulate its contents.
❗️ Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.Typical MistakesfromBEMlesson theory are checked.