add task solution #4673
add task solution #4673
Conversation
There was a problem hiding this comment.
Great job on your submission! 🎉 While there are a couple of minor issues, such as the self-closing form tags and the invalid font-size descriptor in the @font-face rule, these do not significantly impact the functionality of your code. You've met the core requirements of the task, and your implementation is solid. Keep up the good work, and consider addressing these minor points in future projects to enhance your code quality even further! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <form | ||
| class="searchbar" | ||
| data-qa="big" | ||
| > |
There was a problem hiding this comment.
HTML5 does not support self-closing form tags. You should use separate opening and closing tags for the form element, like <form>...</form>.
| <form | ||
| data-qa="small" | ||
| class="searchbar" | ||
| > |
There was a problem hiding this comment.
Similar to the previous form, this form tag should not be self-closing. Use <form>...</form> instead.
| font-family: Avenir; | ||
| src: url('fonts/Avenir-Book.ttf') format('truetype'); | ||
| font-weight: normal; | ||
| font-size: normal; |
There was a problem hiding this comment.
The font-size property is not a valid descriptor for @font-face. You should remove this line as it does not affect the font loading.
| font-family: Avenir; | ||
| src: url('fonts/Avenir-Heavy.ttf') format('truetype'); | ||
| font-weight: bold; | ||
| font-size: normal; |
There was a problem hiding this comment.
Similar to the previous @font-face rule, the font-size property is not valid here and should be removed.
DEMO LINK
TEST REPORT LINK
Icon implemented using background-image CSS property
Inputs are written inside of 'form' tag with correctly passed attributes
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️