Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

solution #31

wants to merge 2 commits into from

Conversation

serhiik05
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task requirements! 🎉 The code is well-structured and follows FastAPI conventions. While there are a couple of minor issues, such as the duplicated import statement and the need for get_single_movie to return a response model instance, these do not critically impact the functionality. Keep up the good work and consider addressing these minor points for cleaner code in the future! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +2 to +3
from typing import Annotated
from fastapi import APIRouter, Depends, HTTPException, Query, Request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import statement for APIRouter, Depends, HTTPException, and Query is duplicated. You should remove one of these import lines to avoid redundancy.


# Write your code here
return film

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function get_single_movie should return an instance of MovieDetailResponseSchema instead of the raw film object. This ensures that the response adheres to the defined schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants