Solution #781
Solution #781
Conversation
app/Battle/battle.py
Outdated
|
|
||
|
|
||
| def battle(knights: dict) -> dict: | ||
| # apply weapon |
There was a problem hiding this comment.
Remove these comments, the code is self-explicit enough
app/Battle/__init__.py
Outdated
There was a problem hiding this comment.
Please, use lower case in directory names here and in the other places as well
app/Battle/battle.py
Outdated
| first_knight = knights_list[stats] | ||
| second_knight = knights_list[stats + 2] | ||
| first_knight["hp"] -= (second_knight["power"] | ||
| - first_knight["protection"]) | ||
| second_knight["hp"] -= (first_knight["power"] | ||
| - second_knight["protection"]) | ||
| if first_knight["hp"] <= 0: | ||
| first_knight["hp"] = 0 | ||
| if second_knight["hp"] <= 0: | ||
| second_knight["hp"] = 0 | ||
| result.update({ | ||
| first_knight["name"]: first_knight["hp"], | ||
| second_knight["name"]: second_knight["hp"] | ||
| }) |
There was a problem hiding this comment.
You could place part of the logic that happens in the loop to a separate function for a better readability
There was a problem hiding this comment.
There is no need to create separate file for each function, create a single file utils.py and place armour, potion and weapon functions there
app/main.py
Outdated
|
|
||
|
|
||
| print(battle(KNIGHTS)) | ||
| # battle |
app/main.py
Outdated
| from app.Battle.battle import battle | ||
|
|
||
|
|
||
| knights = { |
There was a problem hiding this comment.
Place knights config to a separate file for better logic separation
There was a problem hiding this comment.
you meant place config like this?
app/main.py
Outdated
|
|
||
| print(battle(KNIGHTS)) | ||
| # battle | ||
| print(battle(knights)) |
There was a problem hiding this comment.
It could be a good idea to use if __name__ == "__main__" here
No description provided.