Solution-py-linter-formatter #1616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nattalli
suggested changes
Sep 18, 2024
app/main.py
Outdated
Comment on lines
21
to
24
| return [ | ||
| format_single_linter_file(key, value) | ||
| for key, value in linter_report.items() | ||
| ] |
There was a problem hiding this comment.
don't use key, value if you already know field names. for example file_path, errors would be better
app/main.py
Outdated
Comment on lines
3
to
6
| ("name" if key == "code" else "source" if key == "filename" else | ||
| "message" if key == "text" else tuple(key.split("_"))[0]): | ||
| ("flake8" if key == "filename" else value) | ||
| for key, value in error.items() if key != "physical_line" |
There was a problem hiding this comment.
not readable code. please, use static key names and choose the correct fields from the dictionary for those keys. for example:
"name": error["code"]
app/main.py
Outdated
Comment on lines
12
to
16
| ("errors" if elem == "error" else elem): | ||
| ([format_linter_error(error) for error in errors] | ||
| if elem == "error" else file_path if elem == "path" else | ||
| "failed" if elem == "status" and errors != [] else "passed") | ||
| for elem in ("error", "path", "status") |
There was a problem hiding this comment.
the same here. also, elem is bad naming for variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.