Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Solution' #1624

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

'Solution' #1624

wants to merge 2 commits into from

Conversation

spa7id
Copy link

@spa7id spa7id commented Sep 11, 2024

No description provided.

Copy link
Contributor

@Nattalli Nattalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve first function, make it readable and easy to understand

app/main.py Outdated
Comment on lines 2 to 7
return {new_key: error[old_key] for new_key, old_key in {
"line": "line_number",
"column": "column_number",
"message": "text",
"name": "code"
}.items()} | {"source": "flake8"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems difficult, and not readable. Do you need to iterate over fields? You can do the same as in the next function

Copy link
Contributor

@Nattalli Nattalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants