implement py-linter-formatter #1637
Conversation
app/main.py
Outdated
| # write your code here | ||
| pass | ||
| return { | ||
| "errors": ([format_linter_error(error) for error in errors]), |
There was a problem hiding this comment.
not a mistake, but you don't need to use additional braces ()- list comprehension is good enough without them
app/main.py
Outdated
| return { | ||
| "errors": ([format_linter_error(error) for error in errors]), | ||
| "path": file_path, | ||
| "status": ("failed" if errors else "passed") |
There was a problem hiding this comment.
the same with braces here
app/main.py
Outdated
| return [format_single_linter_file(path, linter_report.get(path)) | ||
| for path in linter_report] |
There was a problem hiding this comment.
this code is correct but a little bit complex to understand. I believe that using .items() can make it more readable, what do you think?
There was a problem hiding this comment.
also, I don't like that you use 2 different code styles in 1 file. the example from guideline:
both examples are good but use one:)
app/main.py
Outdated
| # write your code here | ||
| pass | ||
| return [ | ||
| format_single_linter_file(*path) for path in linter_report.items() |
There was a problem hiding this comment.
is it correct to name two items just a path? Probably it. would be better to use 2 variables and give them correct name, where first would be really a path
|
maybe this name would be better? |
| pass | ||
| return [ | ||
| format_single_linter_file(*path_and_errors) | ||
| for path_and_errors in linter_report.items() |
There was a problem hiding this comment.
it would be better to use two variables, smth like this:
for file, report in linter_report.items()
but ur solution is also ok
No description provided.