Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1638

wants to merge 2 commits into from

Conversation

zaietsmo
Copy link

No description provided.

Copy link
Contributor

@Nattalli Nattalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I recommend you use one of the following styles in one file:
Знімок екрана 2024-09-18 о 15 40 02

app/main.py Outdated
pass
return [
format_single_linter_file(file, errors)
for file, errors in linter_report.items()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file_path would be better

app/main.py Outdated
# write your code here
pass
return {
"errors": [format_linter_error(err) for err in errors],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error word and err do have not a big difference. Does it need to be shortened?

Copy link

@AnyoneClown AnyoneClown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants