Solution #1641
Open
Solution #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLkaia
suggested changes
Sep 17, 2024
app/main.py
Outdated
Comment on lines
2
to
4
| return {"line": error["line_number"], "column": error["column_number"], | ||
| "message": error["text"], "name": error["code"], | ||
| "source": "flake8"} if len(error) > 0 else {} |
There was a problem hiding this comment.
Suggested change
| return {"line": error["line_number"], "column": error["column_number"], | |
| "message": error["text"], "name": error["code"], | |
| "source": "flake8"} if len(error) > 0 else {} | |
| return { | |
| "line": error["line_number"], | |
| "column": error["column_number"], | |
| "message": error["text"], | |
| "name": error["code"], | |
| "source": "flake8" | |
| } |
Please, place one item per line for this and following cases
There was a problem hiding this comment.
No reason for length check in this task
app/main.py
Outdated
| # write your code here | ||
| return {"line": error["line_number"], "column": error["column_number"], | ||
| "message": error["text"], "name": error["code"], | ||
| "source": "flake8"} if len(error) > 0 else {} | ||
| pass |
There was a problem hiding this comment.
Remove this pass for this and following appearances
app/main.py
Outdated
Comment on lines
9
to
16
| return {"errors": | ||
| [{"line": error["line_number"], | ||
| "column": error["column_number"], | ||
| "message": error["text"], "name": error["code"], | ||
| "source": "flake8"} | ||
| if len(error) > 0 else {} for error in errors], | ||
| "path": file_path, "status": "failed" | ||
| if len(errors) > 0 else "passed"} |
There was a problem hiding this comment.
Use function above instead of duplicating same code
app/main.py
Outdated
Comment on lines
21
to
27
| return [{"errors": | ||
| [{"line": error["line_number"], "column": error["column_number"], | ||
| "message": error["text"], "name": error["code"], | ||
| "source": "flake8"} | ||
| if len(error) > 0 else {} for error in errors], | ||
| "path": name, "status": "failed" if len(errors) > 0 else "passed"} | ||
| for name, errors in linter_report.items()] |
LLkaia
suggested changes
Sep 17, 2024
app/main.py
Outdated
Comment on lines
16
to
17
| "status": "failed" | ||
| if len(errors) > 0 else "passed" |
There was a problem hiding this comment.
Suggested change
| "status": "failed" | |
| if len(errors) > 0 else "passed" | |
| "status": "failed" if errors else "passed" |
app/main.py
Outdated
Comment on lines
8
to
9
| } \ | ||
| if len(error) > 0 else {} |
There was a problem hiding this comment.
Suggested change
| } \ | |
| if len(error) > 0 else {} | |
| } |
Since we are not expecting that someone will call this function with wrong data. Otherwise, you need to check if all keys exist in this dict, but this is not needed to be implemented in scope of this task.
viktoria-rybenchuk
suggested changes
Sep 17, 2024
app/main.py
Outdated
Comment on lines
8
to
12
| if | ||
| len(error) > 0 and "line_number" in error.keys() | ||
| and "column_number" in error.keys() | ||
| and "text" in error.keys() and "code" in error.keys() | ||
| else {} |
pavlopro
suggested changes
Sep 17, 2024
app/main.py
Outdated
| # write your code here | ||
| pass | ||
| return [format_single_linter_file(file_path=key, errors=errors) | ||
| for key, errors in linter_report.items()] |
There was a problem hiding this comment.
Please use proper variable names. Instead of key use something like report_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.