Solution #1663
Open
Solution #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y-Havryliv
suggested changes
Sep 24, 2024
| # write your code here | ||
| pass | ||
| return { | ||
| "errors": [ |
There was a problem hiding this comment.
it's better to reuse format_linter_error to format errors
|
|
||
|
|
||
| def format_linter_report(linter_report: dict) -> list: | ||
| # write your code here | ||
| pass | ||
| return [ |
There was a problem hiding this comment.
and here you can reuse format_single_linter_file
AnyoneClown
suggested changes
Sep 25, 2024
app/main.py
Outdated
Comment on lines
1
to
8
| def format_linter_error(error: dict) -> dict: | ||
| # write your code here | ||
| pass | ||
| return { | ||
| "line": error["line_number"], | ||
| "column": error["column_number"], | ||
| "message": error["text"], | ||
| "name": error["code"], | ||
| "source": "flake8" | ||
| } |
There was a problem hiding this comment.
Use get() method for dict, in case if you don't have some key inside of your dict and you will try to get it with [key] - it will give you error
app/main.py
Outdated
| # write your code here | ||
| pass | ||
| return [ | ||
| format_single_linter_file(filepath, issues) |
There was a problem hiding this comment.
Python is using snake_case. So, it should be file_path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.