Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1689

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Solution #1689

wants to merge 3 commits into from

Conversation

okdzeryn
Copy link

@okdzeryn okdzeryn commented Oct 1, 2024

No description provided.

app/main.py Outdated
Comment on lines 22 to 25
return [{"path": path,
"errors": [format_linter_error(error) for error in errors],
"status": "failed" if errors else "passed"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use function format_single_linter_file instead

app/main.py Outdated
"message": error["text"],
"name": error["code"],
"source": "flake8"
}
pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed. Remove keyword - pass

app/main.py Outdated
"errors": [format_linter_error(error) for error in errors],
"path": file_path,
"status": "failed" if errors else "passed"
}
pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here

app/main.py Outdated
"errors": [format_linter_error(error) for error in errors],
"status": "failed" if errors else "passed"
}
for path, errors in linter_report.items()]
pass
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@okdzeryn okdzeryn requested a review from LLkaia October 1, 2024 15:02
app/main.py Outdated
"message": error["text"],
"name": error["code"],
"source": "flake8"
}
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed. Remove keyword - pass

app/main.py Outdated
"errors": [format_linter_error(error) for error in errors],
"path": file_path,
"status": "failed" if errors else "passed"
}
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here

app/main.py Outdated
"errors": [format_linter_error(error) for error in errors],
"status": "failed" if errors else "passed"
}
for path, errors in linter_report.items()]
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

Copy link

@viktoria-rybenchuk viktoria-rybenchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants