-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1689
base: master
Are you sure you want to change the base?
Solution #1689
Conversation
app/main.py
Outdated
return [{"path": path, | ||
"errors": [format_linter_error(error) for error in errors], | ||
"status": "failed" if errors else "passed" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use function format_single_linter_file
instead
app/main.py
Outdated
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed. Remove keyword - pass
app/main.py
Outdated
"errors": [format_linter_error(error) for error in errors], | ||
"path": file_path, | ||
"status": "failed" if errors else "passed" | ||
} | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same here
app/main.py
Outdated
"errors": [format_linter_error(error) for error in errors], | ||
"status": "failed" if errors else "passed" | ||
} | ||
for path, errors in linter_report.items()] | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
app/main.py
Outdated
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed. Remove keyword - pass
app/main.py
Outdated
"errors": [format_linter_error(error) for error in errors], | ||
"path": file_path, | ||
"status": "failed" if errors else "passed" | ||
} | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same here
app/main.py
Outdated
"errors": [format_linter_error(error) for error in errors], | ||
"status": "failed" if errors else "passed" | ||
} | ||
for path, errors in linter_report.items()] | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
No description provided.